Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-close PRs that are force-pushed for Oppia and Oppia Android #298

Open
BenHenning opened this issue Feb 4, 2022 · 4 comments
Open

Auto-close PRs that are force-pushed for Oppia and Oppia Android #298

BenHenning opened this issue Feb 4, 2022 · 4 comments
Labels
enhancement New feature or request Impact: Medium Work: Low

Comments

@BenHenning
Copy link
Member

BenHenning commented Feb 4, 2022 •
edited by seanlip
Loading

Is your feature request related to a problem? Please describe.
The Oppia and Oppia Android repos currently permit force-pushing despite it being against developer policy.

Describe the solution you'd like
We ought to automatically close force-pushed PRs and leave a comment that points to the wiki to explain why it was closed (i.e. https://github.com/oppia/oppia-android/wiki/Making-a-code-change).

Describe alternatives you've considered
N/A

Additional context
None
@seanlip
Copy link
Member

seanlip commented Feb 15, 2022 •
edited
Loading

I think we should also do this on the Oppia-web repo, if we haven't already. /cc @vojtechjelinek @DubeySandeep @U8NWXD

@U8NWXD
Copy link
Member

U8NWXD commented Feb 16, 2022

I agree that this would be good for oppia-web too

@vojtechjelinek
Copy link
Contributor

Agreed, @gp201 would you have time to look into this?

@BenHenning
Copy link
Member Author

To clarify: I didn't realize that this wasn't already enabled in Oppia web, so I've updated the PR description to be less confusing.

@U8NWXD U8NWXD moved this from Triage to Not Started in Developer Workflow Team Nov 1, 2022
@seanlip seanlip mentioned this issue Jan 6, 2023
Closed
@seanlip seanlip changed the title [Oppia Android] Please enable force push autoclose for Oppia Android Please enable force push autoclose for Oppia and Oppia Android Jan 6, 2023
@seanlip seanlip changed the title Please enable force push autoclose for Oppia and Oppia Android Enable force push autoclose for Oppia and Oppia Android Jan 6, 2023
@seanlip seanlip mentioned this issue Jan 6, 2023
Closed
@seanlip seanlip changed the title Enable force push autoclose for Oppia and Oppia Android Auto-close PRs that are force-pushed for Oppia and Oppia Android Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Impact: Medium Work: Low
Projects
Developer Workflow Team
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vojtechjelinek @seanlip @BenHenning @U8NWXD