Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oppiabot should not check further in case that PR is already closed #238

Open
Naman-1234 opened this issue Mar 29, 2021 · 3 comments
Open

Comments

@Naman-1234
Copy link
Contributor

Please refer to oppia/oppia#12346

Current Behaviour:
In this since that PR was done using develop branch, Oppiabot closed that Pr,but even after closing it checked Linting checks and tagged undefined to add a label.

Expected Behaviour:
Should not check lint checks and assign reviewers for changelabel, If Pr is already closed.

@vojtechjelinek and @jameesjohn Sir Please tell me if this is a valid issue or not. If yes Please do assign me. I would like to work on this one. Thanks!.

@seanlip
Copy link
Member

seanlip commented Jan 6, 2023

This is a valid issue that can be worked on.

@shubhamsolo
Copy link

@seanlip can i work on this issue ? if yes assign this to me

@seanlip
Copy link
Member

seanlip commented Dec 18, 2024

@shubhamsolo Per the guidance at https://github.com/oppia/oppia/wiki/Contributing-code-to-Oppia#choosing-a-good-first-issue, please provide an explanation of what your PR will do (with names of files you're changing, what you plan to change in each file, etc.), as well as a video showing that the changes work correctly on your local machine. If it looks good, we can assign you to this issue.

See this thread for an example of how another contributor did this: oppia/stale-review-request-notifier#4

Please also follow the other instructions on that wiki page if you have not yet done so. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

4 participants