Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate response time errors #136

Open
jameesjohn opened this issue Oct 2, 2020 · 4 comments
Open

Investigate response time errors #136

jameesjohn opened this issue Oct 2, 2020 · 4 comments
Labels

Comments

@jameesjohn
Copy link
Contributor

We are seeing a lot of response time errors on Heroku: https://dashboard.heroku.com/apps/murmuring-castle-33250.
These errors are resulting in checks being flaky even though the implementation is correct. One of the occurrences was with a CLA check where it did not work on a PR but when investigated later, worked fine.

  • One of the possible reasons for this is the large number of new checks which were added during GSoC.

  • We need to dig deeper into this and find out why these errors are occurring.

    • The way to do this would be to add support for custom logging for oppiabot since Heroku logs are only preserved for 24 hours and we are not able to investigate what is going wrong.
  • Once we are sure, we can look into increasing the number of dynos if required.

@vojtechjelinek
Copy link
Contributor

The error most probably occurs here (I found out about this from logs)

await utilityModule.sleep(utilityModule.THREE_MINUTES);

We will need to respond to the request before the three minutes. So ideal would be to just register the review and respond and after three minutes pass run a separate routine that will check if actions are required and respond if needed.

@jameesjohn
Copy link
Contributor Author

So ideal would be to just register the review

@vojtechjelinek, what do you mean by register the review?

@vojtechjelinek
Copy link
Contributor

Nothing specific, just respond to the request so that it is properly closed so that it doesn't timeout

@himanshusharma27
Copy link

I want to work on this issue . Please assign me this issue .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

5 participants