-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate response time errors #136
Comments
The error most probably occurs here (I found out about this from logs) oppiabot/lib/checkPullRequestReview.js Line 263 in 750df37
We will need to respond to the request before the three minutes. So ideal would be to just register the review and respond and after three minutes pass run a separate routine that will check if actions are required and respond if needed. |
@vojtechjelinek, what do you mean by register the review? |
Nothing specific, just respond to the request so that it is properly closed so that it doesn't timeout |
I want to work on this issue . Please assign me this issue . |
We are seeing a lot of response time errors on Heroku: https://dashboard.heroku.com/apps/murmuring-castle-33250.
These errors are resulting in checks being flaky even though the implementation is correct. One of the occurrences was with a CLA check where it did not work on a PR but when investigated later, worked fine.
One of the possible reasons for this is the large number of new checks which were added during GSoC.
We need to dig deeper into this and find out why these errors are occurring.
Once we are sure, we can look into increasing the number of dynos if required.
The text was updated successfully, but these errors were encountered: