Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeScript warnings #6

Open
michaelsauter opened this issue Jul 5, 2018 · 2 comments
Open

Fix TypeScript warnings #6

michaelsauter opened this issue Jul 5, 2018 · 2 comments

Comments

@michaelsauter
Copy link

TypeScript 2.9.2 reports:

ERROR: (ordered-imports) src/index.ts[4, 1]: Import sources within a group must be alphabetized.
ERROR: (eofline) src/index.ts[17, 4]: file should end with a newline
@rattermeyer
Copy link
Member

Hi,
I've synced with the upstream fork at my local fork https://github.com/rattermeyer/generator-node-express-typescript .
@michaelsauter could you test that?

@michaelsauter
Copy link
Author

The newest version does not work anymore:

ERROR: (no-duplicate-imports) src/index.ts[3, 1]: Multiple imports from 'express' can be combined into one.
ERROR: (ordered-imports) src/index.ts[4, 1]: Import sources within a group must be alphabetized.
ERROR: (no-console) src/index.ts[16, 3]: Calls to 'console.info' are not allowed.

Using TypeScript
Version 2.9.2

> [email protected] build /tmp/workspace/cleme-cd/cleme-cd-be-node-express-npm-update-test
> tsc --pretty

src/index.ts:5:27 - error TS2307: Cannot find module './routes/weather'.

5 import weatherRouter from './routes/weather';
                            ~~~~~~~~~~~~~~~~~~


npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! [email protected] build: `tsc --pretty`
npm ERR! Exit status 2
npm ERR! 
npm ERR! Failed at the [email protected] build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants