Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#145 Follow Up: Update the e2e testing to work when the UnpackImageRegistryClient feature-gate is enabled #163

Closed
everettraven opened this issue Sep 7, 2023 · 0 comments · Fixed by #145

Comments

@everettraven
Copy link
Collaborator

Following #145 , we should update the e2e testing to work even when the UnpackImageRegistryClient feature-gate is enabled. Currently the e2e tests rely on using kubelet to fetch images that have been loaded onto the cluster already via kind. We either need to replicate this behavior in the ImageRegistry source or use a custom image registry for e2e tests (this is the first thing that came to my head - very much so open to other suggestions).

Acceptance Criteria

  • e2e tests pass when the UnpackImageRegistryClient feature-gate is enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant