Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ziti Controller Bootstrap Domain name #2517

Open
u-damien opened this issue Nov 3, 2024 · 0 comments · May be fixed by #2438
Open

Ziti Controller Bootstrap Domain name #2517

u-damien opened this issue Nov 3, 2024 · 0 comments · May be fixed by #2438
Assignees

Comments

@u-damien
Copy link

u-damien commented Nov 3, 2024

Hi,

I can't setup my openziti controller with the bootstrap.bash script because of the following condition:

promptCtrlAddress() {
  if [[ -z "${ZITI_CTRL_ADVERTISED_ADDRESS:-}" || "${ZITI_CTRL_ADVERTISED_ADDRESS}" =~ ^[:0-9] ]]; then
    if ! ZITI_CTRL_ADVERTISED_ADDRESS="$(prompt "Enter DNS name of the controller [required]: ")"; then
      echo "ERROR: missing required DNS name ZITI_CTRL_ADVERTISED_ADDRESS in ${BOOT_ENV_FILE}" >&2
      return 1
      # if an IP address
    elif [[ "${ZITI_CTRL_ADVERTISED_ADDRESS}" =~ ^[:0-9] ]]; then
      echo "ERROR: ZITI_CTRL_ADVERTISED_ADDRESS must be a DNS name" >&2
      return 1
    else
      setAnswer "ZITI_CTRL_ADVERTISED_ADDRESS=${ZITI_CTRL_ADVERTISED_ADDRESS}" "${BOOT_ENV_FILE}"
    fi
  fi
}

The condition for the provided dns name, only check if there are digits in dns name and not if the argument is a valid ip address.
Please use this regex instead so dns containing digits (i.e. 8a1db54a85q97d.example.com) can pass the check: ^[0-9]{1,3}(\.[0-9]{1,3}){3}$

@qrkourier qrkourier self-assigned this Nov 3, 2024
@qrkourier qrkourier linked a pull request Nov 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants