-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add propagation using W3C Trace Context headers #200
Comments
Usually we let PRs come in response to user demand.. are you a user? Regardless, something like this if done in a way safe to the codebase could be helpful in anticipation of demand, for example to allow interop testing. I'd defer to @fedj, but if the code was pluggable and allows for revisions to the spec to not break production users, seems helpful and something we could consider bending "rule of three" on. |
Trying to become one; see #198 (comment)
This is probably the biggest reason not to add it at this point (and something I should have mentioned in the original issue); it may be sensible to wait for the spec to be finalised. I'm happy to keep the code in my own library for now (https://github.com/Faithlife/FaithlifeTracing/pull/1/files#diff-49c766b2446f8555e29e349a8525f2d3) but also contribute it here (to help others) once the W3C recommendation starts getting traction. |
Trying to become one; see #198 (comment)
<#198 (comment)>
thanks!
if the code was pluggable and allows for revisions to the spec to not
break production users
This is probably the biggest reason not to add it at this point (and
something I should have mentioned in the original issue); it may be
sensible to wait for the spec to be finalised.
I'm happy to keep the code in my own library for now (
https://github.com/Faithlife/FaithlifeTracing/pull/1/files#diff-
49c766b2446f8555e29e349a8525f2d3) but also contribute it here (to help
others) once the W3C recommendation starts getting traction.
FYI I plan to make something in brave (java tracer), as we have a
propagation plugin anyway. So, whether here or somewhere else it would be
good to have means to test this. Otherwise the format may have flaws we
don't have a chance to help fix
|
W3C Distributed Trace Context Community Group has an editor's draft of a propagation format for distributed trace context: https://w3c.github.io/distributed-tracing/report-trace-context.html
Would you be interested in receiving a PR that added an
IPropagation<K>
implementation that (de)serializes traces in the W3C format?The text was updated successfully, but these errors were encountered: