-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zimit2: Youtube videos are not working everywhere #291
Comments
This is in fact a Zimit issue, and most probably has nothing to do with Zimit2. I'm transferring it to zimit repo and will give more explanations once transferred. |
I've done some tests with zimit2 and warc2zim2 ( Browsertrix crawler is hence 1.0.0 beta-6 I ran 4 different tests:
Even if testing more readers will be important, conclusion seems pretty clear. ConclusionFor Youtube videos (at least), we must use another userAgent than the current one. Previous work on #229 (where we switched by default to a mandatory UA and choose to use a "desktop-like" UA) was not totally a good idea. It helped solve some problems with Python check of the URL ... but caused other issues like this one. Now that Python check of the URL is gone, we should probably rollback most of PR 229 changes:
I also recommend to set a default Then comes the question of which default mobileDevice to choose. For tests I chose Pixel 2, full list is here: https://github.com/puppeteer/puppeteer/blob/b144935789315697254880015847b2b4d151d52b/packages/puppeteer-core/src/common/Device.ts ; smaller screen might lead to situations where we are served a small asset, which is more or less what we prefer to keep ZIM size small and work on all screen size. This was my logic when I chose Pixel 2 for tests. |
Edit: fix the test table, second device was wrong |
Nota: I've also checked, in all cases the video which is retrieved is identical (same size, same codecs, ...) ... so the "fix" induced by using a more appropriate user-agent is only linked to "other" contents, not to the video codec or stuff like that. |
Solved by #292 |
Just to confirm that the solutions B and D both work in the PWA and the Browser Extension. Was version B the adopted solution? |
Yes, solution B is currently in place in |
To be more precise, by default, "Pixel 2" is used as mobile device. Zimit user is free to override this setting with |
We have to fix the situation where Youtube videos are not working everywhere.
We typically now that they do not play in kiwix-serve on Android Firefox / Chrome (while they should) and it looks like they do not play on kiwix-serve on Windows as well: openzim/warc2zim#206 (comment)
The text was updated successfully, but these errors were encountered: