-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update en.json to fix typos #101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, it is probably way better, I do not have sufficient English level to assess this in details.
I'm however disturbed by the way we name the "final outcome". Sometimes we call it a ZIM
(e.g. in ZIM requested!
), sometimes a zim file
, sometimes a .zim file
.
On a personal basis, I tend to prefer ZIM
, or .zim file
if ZIM
is too short / imprecise / confusing. I find that ZIM file
is too long, zim file
does not match our convention of using uppercase letters. .zim file
looks a bit ugly to me (but it is the most precise one). And we must not forget this is going to be translated, so the simplest, the best from my PoV.
@kelson42 any views to share on this?
And is this the only fix needed regarding #93 or just "preparatory" work? |
Not fully addressing #93, and yes I'm equally undecided on the .zim/ZIM thing. |
@kelson42 up, we need to make a decision on this wording and I know it is important for you if I'm not mistaken |
Thank you for asking, the answer is straight and there is only one: this is a "ZIM" file. |
@Popolechien can you update your PR accordingly (using |
@benoit74 Done. But this here is my first time ever changing a PR, so do make sure I did the right thing at the right place. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
=======================================
Coverage 46.11% 46.11%
=======================================
Files 10 10
Lines 386 386
Branches 44 44
=======================================
Hits 178 178
Misses 206 206
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Thanks, it was almost OK, just had to also fix automated tests which are based on these strings because they were now failing. But this is clearly a bit tricky. Thanks! |
General copyediting
As requested zim -> ZIM
079b626
to
2a9c1f5
Compare
General copyediting.