Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update en.json to fix typos #101

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Update en.json to fix typos #101

merged 3 commits into from
Dec 3, 2024

Conversation

Popolechien
Copy link
Contributor

General copyediting.

@Popolechien Popolechien requested a review from benoit74 November 28, 2024 08:17
Copy link
Collaborator

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, it is probably way better, I do not have sufficient English level to assess this in details.

I'm however disturbed by the way we name the "final outcome". Sometimes we call it a ZIM (e.g. in ZIM requested!), sometimes a zim file, sometimes a .zim file.

On a personal basis, I tend to prefer ZIM, or .zim file if ZIM is too short / imprecise / confusing. I find that ZIM file is too long, zim file does not match our convention of using uppercase letters. .zim file looks a bit ugly to me (but it is the most precise one). And we must not forget this is going to be translated, so the simplest, the best from my PoV.

@kelson42 any views to share on this?

@benoit74
Copy link
Collaborator

And is this the only fix needed regarding #93 or just "preparatory" work?

@Popolechien
Copy link
Contributor Author

Not fully addressing #93, and yes I'm equally undecided on the .zim/ZIM thing.

@benoit74
Copy link
Collaborator

benoit74 commented Dec 2, 2024

@kelson42 up, we need to make a decision on this wording and I know it is important for you if I'm not mistaken

@kelson42
Copy link
Contributor

kelson42 commented Dec 2, 2024

@kelson42 up, we need to make a decision on this wording and I know it is important for you if I'm not mistaken

Thank you for asking, the answer is straight and there is only one: this is a "ZIM" file.

@benoit74
Copy link
Collaborator

benoit74 commented Dec 3, 2024

@Popolechien can you update your PR accordingly (using ZIM file everywhere) or do you wanna help on this?

@Popolechien
Copy link
Contributor Author

Popolechien commented Dec 3, 2024

@benoit74 Done. But this here is my first time ever changing a PR, so do make sure I did the right thing at the right place.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.11%. Comparing base (0e59ae5) to head (2a9c1f5).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #101   +/-   ##
=======================================
  Coverage   46.11%   46.11%           
=======================================
  Files          10       10           
  Lines         386      386           
  Branches       44       44           
=======================================
  Hits          178      178           
  Misses        206      206           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74
Copy link
Collaborator

benoit74 commented Dec 3, 2024

Thanks, it was almost OK, just had to also fix automated tests which are based on these strings because they were now failing. But this is clearly a bit tricky. Thanks!

Popolechien and others added 3 commits December 3, 2024 15:03
General copyediting
As requested zim -> ZIM
@benoit74 benoit74 force-pushed the Popolechien-UI-grammar-fixes branch from 079b626 to 2a9c1f5 Compare December 3, 2024 15:03
@benoit74 benoit74 self-requested a review December 3, 2024 15:05
@benoit74 benoit74 merged commit 21141c5 into main Dec 3, 2024
7 checks passed
@benoit74 benoit74 deleted the Popolechien-UI-grammar-fixes branch December 3, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants