Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FootballDatabse pages always display a cookie banner #1219

Open
1 of 13 tasks
kelson42 opened this issue Nov 28, 2024 · 5 comments
Open
1 of 13 tasks

FootballDatabse pages always display a cookie banner #1219

kelson42 opened this issue Nov 28, 2024 · 5 comments
Assignees
@benoit74
Labels
Bug Something isn't working

Comments

@kelson42
Copy link
Collaborator

ZIM(s) location

https://library.kiwix.org/viewer#footballdatabase.com_en_all_2024-11

Recipe(s) URL

https://farm.openzim.org/recipes/footballdatabase.com_en

Readers tested

  • Kiwix-serve on iOS (iPad / iPhone)
  • Kiwix-serve on Android (phone or tablet)
  • Kiwix-serve on Windows
  • Kiwix-serve on Linux
  • Kiwix-serve on Raspberry Pi (e.g. hotspot)
  • Kiwix-serve on Mac
  • pwa.kiwix.org
  • Kiwix JS - Chrome extension
  • Kiwix JS - Firefox extension
  • Kiwix JS - Edge extension
  • Kiwix for Android application
  • Kiwix for MacOS application
  • Kiwix for iOS (iPad/iPhone) application

Which ZIM versions are impacted?

All PROD versions are impacted

Details

See screenshot
Image

It should not display it at all

In addition, searchbox should be hidden
@kelson42 kelson42 added the Bug Something isn't working label Nov 28, 2024
@benoit74
Copy link
Contributor

CSS configured, running in dev to confirm

@benoit74
Copy link
Contributor

@Popolechien @kelson42 can you please have a look at https://dev.library.kiwix.org/viewer#footballdatabase.com_en_all_2024-11/footballdatabase.com/ and confirm I did not missed something?

@benoit74 benoit74 self-assigned this Nov 29, 2024
@kelson42
Copy link
Collaborator Author

@benoit74 LGTM! Thank you!

@Popolechien
Copy link
Collaborator

LGTM too, thanks.

@benoit74
Copy link
Contributor

Requested in prod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benoit74 benoit74

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kelson42 @benoit74 @Popolechien