-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add utility function to compute/check ZIM descriptions #111
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 32 32
Lines 1302 1319 +17
=========================================
+ Hits 1302 1319 +17
☔ View full report in Codecov by Sentry. |
d4c2453
to
9fd0fff
Compare
…lt and user provided values
…ks on dev machine
…s used by default)
9fd0fff
to
1eaa484
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected ; thank you but this new Descriptions
class is uncalled for. We don't want to extend the API surface which such a thing. I believe returning a tuple here is appropriate.
@benoit74 I had this stashed. Can you review this commit? |
It's ok for me, and I've added my CHANGELOG. |
Fix #110
Changes:
compute_descriptions
ininputs.py
to compute ZIM-compliant descriptions based on default and user-provided valuestox
configurationhandle_user_provided_file
ininputs.py