Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the i18n translation system #134

Closed
benoit74 opened this issue Feb 13, 2024 · 2 comments · Fixed by #187
Closed

Remove the i18n translation system #134

benoit74 opened this issue Feb 13, 2024 · 2 comments · Fixed by #187
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@benoit74
Copy link
Collaborator

Currently, for i18n we rely directly on system locale. We should depend on and use an external locale-data such as what Babel does.

This would provide a real support for Alpine Linux for instance (see #133 (review) for more context / details about Alpine issue) and less system-dependent behaviors.

We have to check all our use cases to check how to implement this with minimal/no impact.

@benoit74 benoit74 added the enhancement New feature or request label Feb 13, 2024
This was referenced Feb 13, 2024
@benoit74 benoit74 added this to the 4.0.0 milestone Aug 2, 2024
@benoit74 benoit74 changed the title Change the i18n system Remove the i18n translation system Aug 5, 2024
@benoit74
Copy link
Collaborator Author

benoit74 commented Aug 5, 2024

After discussing with @rgaudin it is clear that we do not really have a precise idea of how localization should work. So for 4.0.0 we will rather remove i18n translation. It is anyway rarely used by scrapers: ted => barely translated in Hindi, not used in Zimfarm ; openedx => barely translated in Hindi, not working anymore ; nautilus => only translated to FR.

Plan is to confirm what is the proper API and proper way of doing translations across scrapers without current issues on system dependencies.

@benoit74
Copy link
Collaborator Author

benoit74 commented Aug 5, 2024

See #188 for the return of translation support in python-scraperlib

@benoit74 benoit74 self-assigned this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant