-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically update WEEK_4 WEEK_12 versions #2585
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh.. I'd coded something like this before and deleted it because it scared me a little.
My fear is that something will break in the middle of the night, not directly correlatable to a CL because the return value changed due to the datetime. I.e. maybe you have a plugin that doesn't support TanOp, we find that when we try to bump the MIN version and run CI.
With this change, we'd find it at 1AM when CI on a JAX PR starts failing for unrelated reasons.. open to discussing further but time APIs seem super risky IMO.
For convenience we can use this py script to get WEEK_4 and WEEK_12 tag / tag date / days ago Maybe add it to one of the documents? |
Actually this is super useful! We can add this to our weekly integrate / version bump script. Tag the latest release, check if the values should be updated, bump the Mind sending this PR as a |
049622f
to
e06da83
Compare
Added See Usage Example in the PR description above |
Updated the script to use the following git command to get tag_ts and tag_name
This command retrieves the actual tagger date, which represents the date the tag was created, rather than the date of the last commit in the tag. |
f2e7bff
to
5aeb452
Compare
This PR adds
update_version_h_cpp.sh
scriptThe script will:
WEEK_4
andWEEK_12
versions based on Version tag date and current date.This script should be executed at the beginning of the next development cycle, after performing the git tagging.
This script:
stablehlo/dialect/Version.h
New version will be (x, y, z + 1)
Usage Example:
Result: