Accounts Manager breaks if a user has a permission level that is not defined in %userRoles

[dlglin]

To reproduce: add a user to a course with a permission level that is not defined in the %userRoles hash for that course.

If you visit the Accounts Manager you get the error "maketext requires at least one parameter at /opt/webwork/webwork2/lib/Mojolicious/WeBWorK.pm line 110."

The way I came across this is that I had a course with a new role defined in course.conf, and I created a new course and copied instructors from that course. Now I have a new course with a user with permission level 11, but the new course doesn't have a role associated with that permission level.

The other way this could occur is if you archive a course on a server with custom roles defined, and then unarchive it on a server that is missing those custom roles.

The issue appears to be at

webwork2/templates/ContentGenerator/Instructor/UserList/user_list_field.html.ep

Line 54 in df4b848

<%= maketext((grep { $ce->{userRoles}{$_} eq $value } keys %{ $ce->{userRoles} })[0]) %>

If there is no entry in the hash associated with the permission level then you end up passing nothing to maketext.