Upgrade python to version 3.12 #3067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamshale
force-pushed
the
upgrade-python
branch
2 times, most recently
from
ccef483 to
c88c8f4
Compare
jamshale
changed the title
|
I think we can ignore the security issue reported. It's to do with running the demo image as root user. |
ianco
reviewed
Jul 4, 2024
ianco
previously approved these changes
Jul 4, 2024
Signed-off-by: jamshale <[email protected]>
Signed-off-by: jamshale <[email protected]>
Signed-off-by: jamshale <[email protected]>
Signed-off-by: jamshale <[email protected]>
Signed-off-by: jamshale <[email protected]>
Signed-off-by: jamshale <[email protected]>
Signed-off-by: jamshale <[email protected]>
Signed-off-by: jamshale <[email protected]>
|
ianco
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes all usage of python 3.9 to 3.12. There was almost no changes to code needed.
The only changes were in the demo and the
wait_forfunction call had a change in arguments. Also one unit test assertion, and a timing or race condition issue with one integration test. I believe might be caused by speed improvements with python. A small sleep statement seemed to solve it.The acapy docker images for 3.12 obviously aren't available yet and all of the demos that use docker images should be updated later after release.