Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deep Linking for QR codes #627

Open
alexfigtree opened this issue Jul 16, 2024 · 4 comments
Open

Deep Linking for QR codes #627

alexfigtree opened this issue Jul 16, 2024 · 4 comments
Assignees

Comments

@alexfigtree
Copy link
Contributor

alexfigtree commented Jul 16, 2024

Error pops up whenever user tries to scan QR code:

"There was an error encountered when parsing this QR code"

Image

Occurs with any scan, both iOS and Android.

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://claim.dcconsortium.org/?token=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpZCI6IjY2NjljMjFjNjc4OWRkMWY0MjZkODk5ZiIsImlhdCI6MTcxODIwNzA3MywiZXhwIjoxNzE5NDE2NjczfQ.SDw1iWgNaIIBfuCDf0KEg_TufwiGWJ7VnkbbO3kk21g

  2. Scan via phone camera (works)

  3. Scan via QR code on app (works)

Expected behavior
Should work in both scenarios

Screenshots
If applicable, add screenshots to help explain your problem.

@alexfigtree alexfigtree converted this from a draft issue Jul 16, 2024
@alexfigtree alexfigtree added the bug Schedule this bug label Jul 16, 2024
@dmitrizagidulin
Copy link
Contributor

@alexfigtree can you provide an example QR code that you're scanning?

@alexfigtree
Copy link
Contributor Author

alexfigtree commented Sep 4, 2024

Plain text vs cbor qr codes needed for testing, look in
digitalcredentials/docs#10

@alexfigtree alexfigtree moved this from LCW Backlog to To Do (Current sprint) in DCC Engineering Sep 24, 2024
@alexfigtree
Copy link
Contributor Author

@dmitrizagidulin Correction, the QR codes in #10 all work. Here is one that doesn't, seems to be a deeplink issue:

Screenshot 2024-11-21 at 11 46 11 AM

Which corresponds to:

{ "@context": [ "https://www.w3.org/ns/credentials/v2" ], "type": [ "VerifiablePresentation" ], "verifiableCredential": [ { "type": [ "VerifiableCredential", "OpenBadgeCredential" ], "name": "Bachelors", "issuer": { "url": "https://digitalcredentials.mit.edu/", "type": "Profile", "name": "DCC Demo University", "image": { "id": "https://github.com/digitalcredentials/test-files/assets/206059/3f3e1476-fd1e-4c8f-a560-5cfb4017bbc3", "type": "Image" }, "id": "did:key:z6MknNQD1WHLGGraFi6zcbGevuAgkVfdyCdtZnQTGWVVvR5Q" }, "@context": [ "https://www.w3.org/2018/credentials/v1", "https://purl.imsglobal.org/spec/ob/v3p0/context-3.0.1.json", "https://www.w3.org/ns/credentials/status/v1", "https://w3id.org/security/suites/ed25519-2020/v1" ], "credentialSubject": { "type": [ "AchievementSubject" ], "name": "John Doe", "achievement": { "type": [ "Achievement" ], "name": "Bachelors", "image": { "id": "https://github.com/digitalcredentials/docs/assets/206059/9290e932-d9b7-416e-8365-5987aa168e90", "type": "Image" }, "criteria": { "type": "Criteria", "narrative": "This demo credential represents the experience of claiming the credential into the Learner Credential Wallet. Recipients are encouraged to explore share options where they may create unique, verifiable urls to share online and on LinkedIn.\n\n Look for share options in the three dot menu in the top right corner of the app when the credential is being viewed." }, "description": "DCC wallet experience demo credential", "achievementType": "competency" }, "id": "did:key:z6MksEJFvLFdYUBmg54ApSPfi2Kv83yVjjXUJpWPmHpCDq1g" }, "id": "urn:uuid:673f61f30c1463d3552cb5e2", "credentialStatus": { "id": "https://dashboard.dcconsortium.org/status/Rf99JCoURZYaWDLsOsOD#20", "type": "BitstringStatusListEntry", "statusPurpose": "revocation", "statusListCredential": "https://dashboard.dcconsortium.org/status/Rf99JCoURZYaWDLsOsOD", "statusListIndex": "20" }, "issuanceDate": "2024-11-21T16:48:11Z", "proof": { "type": "Ed25519Signature2020", "created": "2024-11-21T16:48:11Z", "verificationMethod": "did:key:z6MknNQD1WHLGGraFi6zcbGevuAgkVfdyCdtZnQTGWVVvR5Q#z6MknNQD1WHLGGraFi6zcbGevuAgkVfdyCdtZnQTGWVVvR5Q", "proofPurpose": "assertionMethod", "proofValue": "z4DVcYoAfXja1fVkJ6mGzgmwRUi5rFGUnQHDGt4UkVeEPvWAeKRgfdrAH6zRMrUWJBmgtfUfJb2AXyiK7xxQJd8c" } } ] }

@alexfigtree
Copy link
Contributor Author

QR codes for testing can be obtained through the claim page of our demo issuer: https://dashboard.dcconsortium.org/, use wallet template and correct email address to receive cred via email and then click on link.

@alexfigtree alexfigtree removed the bug Schedule this bug label Nov 22, 2024
@alexfigtree alexfigtree changed the title There was an error encountered when parsing this QR code Deep Linking for QR codes Nov 22, 2024
@alexfigtree alexfigtree moved this to In Progress in Learner Credential Wallet Dec 5, 2024
@alexfigtree alexfigtree moved this from In Progress to Todo in Learner Credential Wallet Dec 5, 2024
@alexfigtree alexfigtree self-assigned this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants