Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OWF: ViewPropTypes error on Android and iOS #575

Open
alexfigtree opened this issue Mar 5, 2024 · 6 comments
Open

OWF: ViewPropTypes error on Android and iOS #575

alexfigtree opened this issue Mar 5, 2024 · 6 comments
Assignees
Labels
bug Schedule this bug build84 priority

Comments

@alexfigtree
Copy link
Contributor

Describe the bug
ERROR ViewPropTypes will be removed from React Native, along with all other PropTypes. We recommend that you migrate away from PropTypes and switch to a type system like TypeScript. If you need to continue using ViewPropTypes, migrate to the 'deprecated-react-native-prop-types'

To Reproduce
Steps to reproduce the behavior:

  1. Prebuild on either Android or iOS (error appears on both)
  2. npm start, build app
  3. Choose 'development build'
  4. See error

Expected behavior
No errors

Screenshots
Screenshot 2024-02-29 at 9 37 36 AM

Desktop (please complete the following information):
N/A

Smartphone (please complete the following information):

  • Devices, Simulators (Android: Pixel 3, iPhone 15 pro new)
  • OS: Latest
  • Browser: N/A

Additional context
N/A

@alexfigtree alexfigtree added bug Schedule this bug priority labels Mar 5, 2024
@alexfigtree alexfigtree moved this to LCW Backlog in DCC Engineering Mar 6, 2024
@alexfigtree alexfigtree changed the title LCW: ViewPropTypes error on Android and iOS OWF: ViewPropTypes error on Android and iOS Mar 6, 2024
@alexfigtree alexfigtree moved this from LCW Backlog to To Do (Current sprint) in DCC Engineering Mar 6, 2024
@alexfigtree alexfigtree mentioned this issue Feb 28, 2024
9 tasks
@alexfigtree alexfigtree self-assigned this Jun 7, 2024
@alexfigtree alexfigtree moved this from To Do (Current sprint) to In Progress in DCC Engineering Jun 10, 2024
@alexfigtree
Copy link
Contributor Author

PropTypes error can be resolved by upgrading RN, currently on a spike to see how feasible this is

@alexfigtree
Copy link
Contributor Author

@dmitrizagidulin Suggests timeboxing and spinning off this issue as part of a large RN upgrade ticket, should continue OWF handover without addressing this issue for now.

@alexfigtree alexfigtree moved this from In Progress to LCW Backlog in DCC Engineering Jul 18, 2024
@alexfigtree
Copy link
Contributor Author

@dmitrizagidulin Says there is a fix out there for us to look at

@dmitrizagidulin
Copy link
Contributor

May be addressed by PR #636

@kayaelle
Copy link
Contributor

kayaelle commented Dec 4, 2024

@alexfigtree - we may be able to close this one

@alexfigtree
Copy link
Contributor Author

@kayaelle Just tested, still happening, even with the merge from PR #636

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Schedule this bug build84 priority
Projects
Status: No status
Development

When branches are created from issues, their pull requests are automatically linked.

4 participants