-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adding -std=c99 globally #5595
Comments
If we have the dependency anyway, including in non-optional and non-arch-specific code such as PRINCE, then yes we should enable this globally. However, ideally we shouldn't try to add this option unless we know the compiler recognizes it, which means gcc starting with a certain version or compatible. Edit: OTOH, if it's a version of gcc so old it doesn't recognize the option, then it's also too old to build the code anyway, so for gcc we should probably add this option unconditionally. |
-std=c99 breaks anonymous structs/unions with gcc-4 (only). Closes openwall#5595
Using -std=c99 breaks anonymous structs/unions with gcc-4 (only). Closes openwall#5595
gcc 4.4 (only) does not allow anonymous structs/unions with Using |
While investigating this I also found out that strictly speaking, only |
Currently (off the top of my head) the PRINCE mode and the new AES needs it. Perhaps we should just enable it globally. I don't care a lot but I think it would be nice.
The text was updated successfully, but these errors were encountered: