-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GHA] test install #3080
[GHA] test install #3080
Conversation
This reverts commit 92ba9af.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
41f245d
to
6c145a2
Compare
@alexsu52 @MaximProshin what you think about 2 triggers for test install:
Or second trigger can be used as precommit (will be fast test) |
@AlexanderDokuchaev , why do you want to have some checks post merge? Do we often break smth here? |
@MaximProshin not often, but it's cheap, simple, it save time of developer who will investigate falls |
@AlexanderDokuchaev I would consider to add the fast test to the precommit. This solution looks better than introducing post-merge phase but dependent on test time. Could you share test time of only cpu, only one build_s, only linux? |
0d4e98e
to
2c7fcbe
Compare
8a87865
to
2c58e7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes
Add workflow "Test install"
python -m venv
pip install -e .
Tests
run