Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GHA] test install #3080

Merged
merged 16 commits into from
Nov 25, 2024
Merged

Conversation

AlexanderDokuchaev
Copy link
Collaborator

@AlexanderDokuchaev AlexanderDokuchaev commented Nov 12, 2024

Changes

Add workflow "Test install"

  • Add removable_tmp_path to clean venv after test, to avoid reach space limit on host.
  • Remove test_install_with_tests_requirements
  • Check only python -m venv
  • Split 'helper.py' to run install test without install pip install -e .

Tests

run

@AlexanderDokuchaev AlexanderDokuchaev marked this pull request as ready for review November 12, 2024 23:32
@AlexanderDokuchaev AlexanderDokuchaev requested a review from a team as a code owner November 12, 2024 23:32
Copy link
Contributor

@alexsu52 alexsu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to apply nightly schedule to the install tests, taking into account time of tests
{3460857A-51BA-4F49-A227-28999AC5C4E7}

The install tests should be able to run manually.

@AlexanderDokuchaev
Copy link
Collaborator Author

@alexsu52 @MaximProshin what you think about 2 triggers for test install:

  1. nightly: full test cpu, gpu, all type of installation, linux and windows
  2. post_merge: only cpu, only one build_s, only linux

Or second trigger can be used as precommit (will be fast test)

@MaximProshin
Copy link
Collaborator

@alexsu52 @MaximProshin what you think about 2 triggers for test install:

  1. nightly: full test cpu, gpu, all type of installation, linux and windows
  2. post_merge: only cpu, only one build_s, only linux

Or second trigger can be used as precommit (will be fast test)

@AlexanderDokuchaev , why do you want to have some checks post merge? Do we often break smth here?

@AlexanderDokuchaev
Copy link
Collaborator Author

@MaximProshin not often, but it's cheap, simple, it save time of developer who will investigate falls

@alexsu52
Copy link
Contributor

alexsu52 commented Nov 22, 2024

@AlexanderDokuchaev I would consider to add the fast test to the precommit. This solution looks better than introducing post-merge phase but dependent on test time. Could you share test time of only cpu, only one build_s, only linux?

@AlexanderDokuchaev AlexanderDokuchaev force-pushed the ad/gha_install branch 3 times, most recently from 0d4e98e to 2c7fcbe Compare November 25, 2024 00:36
@github-actions github-actions bot added NNCF TF Pull requests that updates NNCF TensorFlow NNCF PT Pull requests that updates NNCF PyTorch NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF ONNX Pull requests that updates NNCF ONNX labels Nov 25, 2024
@AlexanderDokuchaev
Copy link
Collaborator Author

Copy link
Contributor

@alexsu52 alexsu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexsu52 alexsu52 merged commit e3744b7 into openvinotoolkit:develop Nov 25, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NNCF ONNX Pull requests that updates NNCF ONNX NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF PT Pull requests that updates NNCF PyTorch NNCF TF Pull requests that updates NNCF TensorFlow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants