Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove requirements.txt #3115

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Remove requirements.txt #3115

wants to merge 1 commit into from
+0 −1

Conversation

AlexanderDokuchaev
Copy link
Collaborator

Changes

Removed requirements.txt

Reason for changes

  • requirements.txt that install package is not expected as default behavior to install module in editable mode.
  • editable mode is deprecated
  • requirements.txt not actual after pyproject.toml

@AlexanderDokuchaev AlexanderDokuchaev requested a review from a team as a code owner November 26, 2024 14:18
@github-actions github-actions bot added the dependencies Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM label Nov 26, 2024
alexsu52
alexsu52 approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@alexsu52 alexsu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alexsu52
alexsu52 reviewed Nov 27, 2024
View reviewed changes
Copy link
Contributor

@alexsu52 alexsu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexanderDokuchaev, @MaximProshin, please, estimate impact to 3rd party components and validation.

@AlexanderDokuchaev
Copy link
Collaborator Author

I dont know any place where used pip install -r nncf/requarements.txt to install nncf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexsu52 alexsu52 alexsu52 approved these changes

@MaximProshin MaximProshin Awaiting requested review from MaximProshin

Assignees

@alexsu52 alexsu52

Labels
dependencies Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexanderDokuchaev @alexsu52