Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GHA] tf nighlty #3113

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

[GHA] tf nighlty #3113

wants to merge 3 commits into from
+26 −1

Conversation

AlexanderDokuchaev
Copy link
Collaborator

@AlexanderDokuchaev AlexanderDokuchaev commented Nov 25, 2024 •
edited
Loading

Changes

Add tensorflow nightly test scope

@github-actions github-actions bot added the NNCF TF Pull requests that updates NNCF TensorFlow label Nov 25, 2024
@AlexanderDokuchaev
Copy link
Collaborator Author

https://github.com/openvinotoolkit/nncf/actions/runs/12020588869

@AlexanderDokuchaev AlexanderDokuchaev marked this pull request as ready for review November 26, 2024 00:18
@AlexanderDokuchaev AlexanderDokuchaev requested a review from a team as a code owner November 26, 2024 00:18
alexsu52
alexsu52 approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@alexsu52 alexsu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MaximProshin
MaximProshin reviewed Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@MaximProshin MaximProshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexanderDokuchaev , @alexsu52 , in jenkins we have nncf-tests.xml as the artefact for this job. I suppose it's not available in GHA, right? I personally don't use this file, so maybe it's ok, but maybe others used it before. Please make sure it's ok.

MaximProshin
MaximProshin reviewed Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@MaximProshin MaximProshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexanderDokuchaev , in the last nightly run in Jenkins I see
== 15 passed, 41 skipped, 633 deselected, 801 warnings in 2212.45s (0:36:52) ===
while in GHA it's
== 14 passed, 42 skipped, 633 deselected, 799 warnings in 2410.03s (0:40:10) ===
so it seems there is some misalignment.

@AlexanderDokuchaev
Copy link
Collaborator Author

AlexanderDokuchaev commented Nov 28, 2024 •
edited
Loading

@alexsu52 test_tensor_processor.py on GPU is skipped, is it ok?

nncf/tests/tensorflow/pruning/test_tensor_processor.py

Line 20 in 2db9fb9

def test_create_tensor(device):

CPU tests runs in precommit

@MaximProshin about artifacts, yyes it's not available, i dont use it too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaximProshin MaximProshin MaximProshin left review comments

@alexsu52 alexsu52 alexsu52 approved these changes

Assignees

@alexsu52 alexsu52

Labels
NNCF TF Pull requests that updates NNCF TensorFlow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexanderDokuchaev @alexsu52 @MaximProshin