Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

can't use hostname when set client.host() #2

Open
wangshijun opened this issue May 31, 2015 · 1 comment · May be fixed by #7
Open

can't use hostname when set client.host() #2

wangshijun opened this issue May 31, 2015 · 1 comment · May be fixed by #7
Assignees
@kgryte

Comments

@wangshijun
Copy link

I have multiple tsdb query instances hebind nginx, and I access my data through tsdb.domain.com, when I use this library, an IP must be used when set client.host(), why doest opentsdb-client not support hostnames?
@kgryte
Copy link
Contributor

kgryte commented May 31, 2015

Thanks for the bringing this to my attention. The reason why the lib does not support hostnames is that I never had the use case; OpenTSDB instances were registered in a service registry via their IP.

Feel free to fork and submit a pull request to provide hostname support. Thanks!

@kgryte kgryte self-assigned this Mar 1, 2016
zsoldosp added a commit to zsoldosp/client that referenced this issue Oct 24, 2017
@zsoldosp
allow ignoring host validation to be IP or localhost
22586fe 
fixes opentsdb-js#2

instead of trying to verify/parse all the possible
available domain name formats (which now include more
than just ascii chars), this approach allows the calling
client to explicitly disable host/ip verification.

This change is backwards compatible, relying on a new, optional
argument.
@zsoldosp zsoldosp linked a pull request Oct 24, 2017 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kgryte kgryte

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow ignoring host validation to be IP or localhost zsoldosp/client
2 participants
@wangshijun @kgryte