Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managing Context across App Domains #136

Open
notcool11 opened this issue Apr 13, 2020 · 1 comment
Open

Managing Context across App Domains #136

notcool11 opened this issue Apr 13, 2020 · 1 comment

Comments

@notcool11
Copy link

Ran into this issue recently in a Unit Test and uncovered a possible issue that could happen in production code:
https://stackoverflow.com/questions/5439719/is-it-possible-to-use-the-logical-call-context-within-a-unit-test-in-vs-2010

Trying to keep the IScope around but it is not marked as either Serializable or MarshalByRefObject so it dies when being used across app domains. Likely the easy button is to mark it as Serializable, but I'm cool with whatever. Thanks.

@cwe1ss
Copy link
Member

cwe1ss commented Dec 12, 2020

This library only defines the interfaces and I don't think interfaces can be marked as Serializable so this is something that each tracer would have to implement. Also, AppDomains are no longer supported in .NET Core & .NET 5 onwards so I don't think this is something that's still important for this project (given that it's being replaced by OpenTelemetry).

I'll leave this open though to see if anyone else has an opinion on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants