Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vonage video api support #845

Open
wants to merge 28 commits into
base: vonage
Choose a base branch
from
Open

Add vonage video api support #845

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
70818c6
Initial work for Vonage application support
jeffswartz Aug 16, 2022
203dd2a
README edits for Vonage application
jeffswartz Aug 16, 2022
710ba3a
Update @vonage/video version
jeffswartz Aug 16, 2022
6935ecc
Change the Vonage Video web client URL
jeffswartz Aug 16, 2022
ea8f4a4
API tests for Vonage applications
jeffswartz Aug 18, 2022
4c08e1d
README info on OpenTok.js URL (to https://unpkg.com/@vonage...)
jeffswartz Oct 5, 2022
aa34771
update to latest @vonage/video SDK
jeffswartz Oct 5, 2022
7eb6561
Remove separate App ID for precall test
jeffswartz Oct 5, 2022
75a6a24
Disable SIP in UI
jeffswartz Oct 5, 2022
760688c
Remove unused OpenTok server SDK mock
jeffswartz Oct 5, 2022
4cfb614
Remove unneeded console.log() call
jeffswartz Oct 5, 2022
209bb48
Fix API tests (for calls to Vonage Video server SDK)
jeffswartz Oct 7, 2022
88e3d72
More test fixes
jeffswartz Oct 11, 2022
9f70391
Change API key and API secret to app ID and private key
jeffswartz Oct 11, 2022
f837c13
Fix for ChatController test stubs
jeffswartz Oct 11, 2022
3c09d54
Fix call to Vonage server SDK sendSignal() method
jeffswartz Oct 12, 2022
57d8812
Rev version to 5.0, and fix node version in package.json
jeffswartz Oct 12, 2022
5cc5557
Fix deleteArchive()
jeffswartz Oct 13, 2022
0bdada4
Remove unneeded console.log() call
jeffswartz Oct 14, 2022
9a9c650
Merge remote-tracking branch 'origin/master' into vonage-application-…
jeffswartz Nov 19, 2022
7db22d9
rev version
jeffswartz Nov 19, 2022
cfae979
Add vonage video api support
haocheng2023 Nov 27, 2023
9b48acc
merge
haocheng2023 Nov 29, 2023
a5fcebe
merge
haocheng2023 Nov 29, 2023
0cbc25e
whitesource check
haocheng2023 Nov 29, 2023
ca75eae
lint
haocheng2023 Dec 1, 2023
de06b1d
change vonage private key path to vonage private key
haocheng2023 Dec 1, 2023
0ad370c
change vonage private key path to vonage private key
haocheng2023 Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/example.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
},
"Vonage":{
"applicationId": "<key>",
"privateKeyPath": "<path>",
"privateKey": "<path>",
"publisherResolution": "640x480"
},
"precallTest": {
Expand Down
2 changes: 1 addition & 1 deletion server/serverConstants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ E.REDIS_ROOM_MATCHES = `${E.REDIS_ROOM_PREFIX}*`;

E.VONAGE_APPLICATION_ID = { envVar: 'VONAGE_APPLICATION_ID', jsonPath: 'Vonage.applicationId', required: true };

E.VONAGE_PRIVATE_KEY_PATH = { envVar: 'VONAGE_PRIVATE_KEY', jsonPath: 'Vonage.privateKeyPath', required: true };
E.VONAGE_PRIVATE_KEY = { envVar: 'VONAGE_PRIVATE_KEY', jsonPath: 'Vonage.privateKey', required: true };

E.OPENTOK_JS_URL = {
envVar: 'TB_JS_URL', jsonPath: 'OpenTok.jsUrl', required: false, defaultValue: 'https://unpkg.com/@vonage/video-client@2/dist/js/opentok.js',
Expand Down
4 changes: 2 additions & 2 deletions server/serverMethods.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ function ServerMethods(aLogLevel, aModules) {
const defaultTemplate = config.get(C.DEFAULT_TEMPLATE);
const templatingSecret = config.get(C.TEMPLATING_SECRET);
const applicationId = config.get(C.VONAGE_APPLICATION_ID);
const privateKeyPath = config.get(C.VONAGE_PRIVATE_KEY_PATH);
const privateKey = config.get(C.VONAGE_PRIVATE_KEY);
const precallApplicationId = applicationId;
const opentokJsUrl = config.get(C.OPENTOK_JS_URL);
const useGoogleFonts = config.get(C.USE_GOOGLE_FONTS);
Expand All @@ -141,7 +141,7 @@ function ServerMethods(aLogLevel, aModules) {

const credentials = new Auth({
applicationId,
privateKey: privateKeyPath,
privateKey: privateKey,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
privateKey: privateKey,
privateKey,

});
const videoInstance = Utils.CachifiedObject(Video, credentials, {});
const allowIframing = config.get(C.ALLOW_IFRAMING);
Expand Down