Add vonage video api support #845
Conversation
Requires Node 14+. Fixes fixes missing connection data in web client.
And remove incorrect info in README about precall test not being supported.
Unsupported for Vonage applications, currently
There was a problem hiding this comment.
This PR appears to disable the use of OpenTok credentials and require Vonage credentials (if we target the master branch). Do we want to create a new vonage-application-support branch (or whatever we want to call it), and have this PR target that branch? Or do we want to change this PR so that it lets you use either OpenTok or Vonage credentials (based on the environment variables on the system)?
There was a problem hiding this comment.
This PR appears to disable the use of OpenTok credentials and require Vonage credentials (if we target the master branch). Do we want to create a new vonage-application-support branch (or whatever we want to call it), and have this PR target that branch? Or do we want to change this PR so that it lets you use either OpenTok or Vonage credentials (based on the environment variables on the system)?
haocheng2023
changed the base branch from
master
to
vonage-application-support
jeffswartz
changed the base branch from
vonage-application-support
to
vonage
| export TB_API_KEY=<key> | ||
| export TB_API_SECRET=<secret> | ||
| export VONAGE_APPLICATION_ID=<application-id> | ||
| export VONAGE_PRIVATE_KEY=<private-key> |
There was a problem hiding this comment.
The code uses VONAGE_PRIVATE_KEY_PATH, right? I actually think VONAGE_PRIVATE_KEY is better, because this can be a path to a private key or the actual private key String, right? If so, please change throughout.
server/archiveLocalStorage.js
Outdated
| (error) => { | ||
| if (error) { | ||
| return this.logger.log('Get archives error:', error); | ||
| } | ||
| return false; | ||
| }, | ||
| } | ||
| ); | ||
| } |
There was a problem hiding this comment.
Lots of linting errors (here and in other files). Please run npm run lint.
server/serverConstants.js
Outdated
| // E.OPENTOK_PRECALL_API_KEY = { envVar: 'TB_PRECALL_API_KEY', jsonPath: 'precallTest.apiKey' }; | ||
|
|
||
| E.OPENTOK_PRECALL_API_SECRET = { envVar: 'TB_PRECALL_API_SECRET', jsonPath: 'precallTest.apiSecret' }; | ||
| // E.OPENTOK_PRECALL_API_SECRET = { envVar: 'TB_PRECALL_API_SECRET', jsonPath: 'precallTest.apiSecret' }; |
There was a problem hiding this comment.
So, I guess we're using the same app ID and secret for the precall session. That makes sense. I think it was a mistake early to have the app use a separate API key and secret for the precall session. (It should use a separate session ID.)
haocheng2023
force-pushed
the
vonage
branch
4 times, most recently
from
d6cb102 to
0ad370c
Compare
| @@ -141,7 +141,7 @@ function ServerMethods(aLogLevel, aModules) { | |||
|
|
|||
| const credentials = new Auth({ | |||
| applicationId, | |||
| privateKey: privateKeyPath, | |||
| privateKey: privateKey, | |||
There was a problem hiding this comment.
| privateKey: privateKey, | |
| privateKey, |
| You can set the `VONAGE_APPLICATION_ID` and `VONAGE_PRIVATE_KEY` environment variables to | ||
| your Vonage application ID and private key. For example, the following shell commands export | ||
| these values for use by the app (replace `<application-id>` and `<private-key>` with your | ||
| Vonage application ID and private key): |
There was a problem hiding this comment.
| Vonage application ID and private key): | |
| Vonage application ID and either the private key or path to the private key): |
| For example, the following shell commands export these values for use by the app | ||
| (replace `<key>` and `<secret>` with your OpenTok API key and the corresponding API secret): | ||
| You can set the `VONAGE_APPLICATION_ID` and `VONAGE_PRIVATE_KEY` environment variables to | ||
| your Vonage application ID and private key. For example, the following shell commands export |
There was a problem hiding this comment.
| your Vonage application ID and private key. For example, the following shell commands export | |
| your Vonage application ID and private key (or path to the private key). For example, the following shell commands export |
|
@jeffswartz or @haocheng2023 Is anything here left?, can this be merged in?, will this get to |
No description provided.