Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: EXPOSE REST API port 8080 #1962

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ajlennon
Copy link

@ajlennon ajlennon commented Aug 4, 2023

As this is needed by the WebUI topology page which interacts with the OTBR REST agent on port 8080

As this is needed by the WebUI topology page which interacts
with the OTBR REST agent on port 8080

Signed-off-by: Alex J Lennon <[email protected]>
@google-cla
Copy link

google-cla bot commented Aug 4, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@scyto
Copy link

scyto commented Jun 11, 2024

I think you will find the rest port is 8081 not 8080 (thats how it is by default when I use macvlan)
i still like the idea of you including it as an EXPOSE

@ajlennon
Copy link
Author

Thanks :) I've been fiddling around as I've been trying to get Traefik to forward requests so I can have everything running over a single port...

@jwhui jwhui requested a review from bukepo July 31, 2024 20:43
@@ -111,3 +111,4 @@ RUN ([ "${DNS64}" = "0" ] || chmod 644 /etc/bind/named.conf.options) \
ENTRYPOINT ["/app/etc/docker/docker_entrypoint.sh"]

EXPOSE 80
EXPOSE 8080:8080
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this valid syntax? I couldn't find it in https://docs.docker.com/reference/dockerfile/#expose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants