Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thoughts on adding a basic Phoenix example? #10

Open
kw7oe opened this issue Jul 24, 2021 · 2 comments
Open

Thoughts on adding a basic Phoenix example? #10

kw7oe opened this issue Jul 24, 2021 · 2 comments

Comments

@kw7oe
Copy link
Contributor

kw7oe commented Jul 24, 2021

Hi, I notice that we have an ongoing work on the phoenix_backend. However, I have not much context on what's the original plan and what's the end goal like.

I have setup a super basic Phoenix + Ecto application integrated with opentelemetry_phoenix and opentelemetry_ecto here. It's based on what we have on basic_elixir, so we have docker compose setup and user can run and play around with it locally with ease.

I'm thinking down the road, we could extend the example to configure otel-collector-config.yaml to export the traces directly to service like honeycomb and Lightstep as well.

Do you think it would be good to include that into this repository as well? If yes, should we replace the existing phoenix_backend example, or create a new folder?

@tsloughter
Copy link
Contributor

Yes, that would be great, including the idea to have it include optional configuration for exporting to services like honeycomb and lightstep.

Phoenix and beam-telemetry in general seem to be where many people will start coming to Otel from with the intention of getting spans and right now I think the docs and examples don't meet them where they are but instead starts from a blank beginning.

@kw7oe
Copy link
Contributor Author

kw7oe commented Jul 31, 2021

Ah great! I'll open a PR soon to include that. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants