Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: union model in promise #107

Merged
merged 11 commits into from
Sep 26, 2023
Merged

fix: union model in promise #107

merged 11 commits into from
Sep 26, 2023

Conversation

bytemain
Copy link
Member

@bytemain bytemain commented Sep 7, 2023

close: #106

@bytemain
Copy link
Member Author

bytemain commented Sep 7, 2023 •
edited
Loading

done

待补充 compose 的测试用例:

https://github.com/koajs/compose/blob/master/test/test.js

@codecov
Copy link

codecov bot commented Sep 7, 2023 •
edited
Loading

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
src/declare.ts 100.00%
src/decorator.ts 100.00%
src/helper/compose.ts 100.00%
src/helper/hook-helper.ts 100.00%

📢 Thoughts on this report? Let us know!.

MMhunter
MMhunter approved these changes Sep 26, 2023
View reviewed changes
src/helper/compose.ts Show resolved Hide resolved
@bytemain bytemain merged commit 015f1e2 into main Sep 26, 2023
4 checks passed
@bytemain bytemain deleted the fix/union-model branch September 26, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MMhunter MMhunter MMhunter approved these changes

@erha19 erha19 Awaiting requested review from erha19

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

使用异步hook时，调用时序有问题
2 participants
@bytemain @MMhunter