iD: listen to URL hash changes #5394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pan to the new `map` location when the hash change was not not triggered by map interaction from inside iD itself. This mirrors the behaviour when manually editing the `map` hash parameter on osm.org outside of iD. This also fixes openstreetmap/iD#10592 (error in js console when iD is opened outside of an iframe by directly navigating to osm.org/id).
|
Looks good to me, though I would not that using openstreetmap.org/id directly is not really supported - it's an internal implementation detail that we certainly don't guarantee. |
👍 agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
maphash parameter is changed (and was not not triggered by map interaction from inside iD itself): pan to the new location.This mirrors the behaviour when manually editing the
maphash parameter on osm.org outside of iD.This also fixes openstreetmap/iD#10592 (error in js console when iD is opened outside of an iframe by directly navigating to osm.org/id).