Group untagged way nodes with same related ways #5393
+151
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #5355.
In #5317 I proposed to make the following change to browse way pages: for way nodes that are also part of other ways, instead of showing those ways inline as "(part of ways ...)" show them as foldable
<details>
. But that takes more vertical space especially if they are not folded by default and the question was whether we should fold them #5317 (review). But I think this is not a very efficient way of saving space because:A more efficient way to save space is to group similar nodes. This PR groups together untagged nodes that have the same related ways. Such nodes are not interesting on their own and don't deserve an entire line spend on them. With the current magnitude of ids and sidebar width we can fit three on one line when there's no scrollbar (and we can tweak letter spacing later to fit three even with a scrollbar). Long sequences of such nodes are expected on natural features, possibly sharing boundaries with other natural features, such as wood-grassland.
Before:
After:
Also fixes #1147.
Before:
After: