Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group untagged way nodes with same related ways #5393

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AntonKhorev
Copy link
Collaborator

@AntonKhorev AntonKhorev commented Dec 11, 2024

Extracted from #5355.

In #5317 I proposed to make the following change to browse way pages: for way nodes that are also part of other ways, instead of showing those ways inline as "(part of ways ...)" show them as foldable <details>. But that takes more vertical space especially if they are not folded by default and the question was whether we should fold them #5317 (review). But I think this is not a very efficient way of saving space because:

  • if a (part of ways) list is short, we're not saving much by folding it
  • long list are rare, therefore we don't save much by folding them either

A more efficient way to save space is to group similar nodes. This PR groups together untagged nodes that have the same related ways. Such nodes are not interesting on their own and don't deserve an entire line spend on them. With the current magnitude of ids and sidebar width we can fit three on one line when there's no scrollbar (and we can tweak letter spacing later to fit three even with a scrollbar). Long sequences of such nodes are expected on natural features, possibly sharing boundaries with other natural features, such as wood-grassland.

Before:
image

After:
image

Also fixes #1147.

Before:
image

After:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Website element display doesn't know about closed ways ...
1 participant