Resourceful routes for traces API #5390
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only for
/api/0.6/gpx/
. There are other trace-related routes such as/api/0.6/user/gpx_files
that are not changed here.A couple of caveats:
gpx/:id/details
since 01cfcbd. Later a standard pathgpx/:id
was added in 71f1554. Both path are currently supported. It's possible to convertdetails
into a nested resource to give it a resourceful route. This will require keeping some copy-pasted code. How about instead we don't do that, keep thedetails
path non-resourceful and deprecate it?gpx/create
. A standard one would be just POST atgpx
. Again it's possible to mapgpx/create
in a hacky way to thecreate
method in the traces controller, or make a nested resource just for creating traces. How about instead we:gpx/create
as non-resourceful and deprecate it?