Disable filter inheritance on tiles, apply filter to tile container #5387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you deliberately trying to break every third-party patch/extension for the website that fixes the dimmed tiles? |
AntonKhorev
force-pushed
the
map-filter-container
branch
from
77182b7 to
b87983c
Compare
|
Looks like the amount of this grid lines effect depends on the filter used. With invert+rotate filters it almost disappears on desktop, but is still significantly noticeable on mobile. But that could be just because the overall brightness of tiles. |
|
Looks good to me, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a filter is applied to every tile separately, it's possible that the gaps between tiles become visible when zooming. I've only seen this happening in Chrome, both on desktop and mobile.
It could have been the reason why I applied the filter to
.leaflet-tile-containerin the first place, which I had to undo in #5330. Now I'm applying the filter to the container again, but I disable the unexpected filer inheritance (which is disabled in the current unreleased Leaflet code).Before:
simplescreenrecorder-2024-12-09_16.13.37.mp4
After:
simplescreenrecorder-2024-12-09_16.11.21.mp4