Skip to content

Commit

Permalink
iD: listen to manual hashchanges from iframe parent
Browse files Browse the repository at this point in the history
Pan to the new `map` location when the hash change was not not triggered by map interaction from inside iD itself.

This mirrors the behaviour when manually editing the `map` hash parameter on osm.org outside of iD.

This also fixes openstreetmap/iD#10592 (error in js console when iD is opened outside of an iframe by directly navigating to osm.org/id).
  • Loading branch information
tyrasd committed Dec 11, 2024
1 parent 985b355 commit 1ba5b7f
Showing 1 changed file with 24 additions and 4 deletions.
28 changes: 24 additions & 4 deletions app/assets/javascripts/id.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,12 @@ document.addEventListener("DOMContentLoaded", function () {
.containerNode(container)
.init();

if (parent === window) {
// iD not opened in an iframe -> skip setting of parent handlers
return;
}

var hashChangedAutomatically = false;
id.map().on("move.embed", parent.$.throttle(250, function () {
if (id.inIntro()) return;
var zoom = ~~id.map().zoom(),
Expand All @@ -40,21 +46,35 @@ document.addEventListener("DOMContentLoaded", function () {
// https://gist.github.com/jfirebaugh/5439412
var hash = parent.OSM.formatHash(llz);
if (hash !== parent.location.hash) {
hashChangedAutomatically = true;
parent.location.replace(parent.location.href.replace(/(#.*|$)/, hash));
}
}));

parent.$("body").on("click", "a.set_position", function (e) {
e.preventDefault();
var data = parent.$(this).data();

function goToLocation(data) {
// 0ms timeout to avoid iframe JS context weirdness.
// https://gist.github.com/jfirebaugh/5439412
setTimeout(function () {
id.map().centerZoom(
[data.lon, data.lat],
Math.max(data.zoom || 15, 13));
}, 0);
}

parent.$("body").on("click", "a.set_position", function (e) {
e.preventDefault();
var data = parent.$(this).data();
goToLocation(data);
});

parent.addEventListener("hashchange", function (e) {
if (hashChangedAutomatically) {
hashChangedAutomatically = false;
return;
}
e.preventDefault();
var data = parent.OSM.mapParams();
goToLocation(data);
});
}
});

0 comments on commit 1ba5b7f

Please sign in to comment.