Fix broken destroy model functionality #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the destroy method and cleans up after pending tasks.
openstack-mirroring
pushed a commit
to openstack/charm-trilio-dm-api
that referenced
this pull request
Feb 26, 2021
func-test-pr: openstack-charmers/zaza#430 Change-Id: I4100771916963b681e760f5e364420f50dc81b9f
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Feb 26, 2021
* Update charm-trilio-dm-api from branch 'master'
to ad428c2e6772d2bf307f181754e9468765c694be
- Extend gate tests for Trilio 4.0 and 4.1
func-test-pr: openstack-charmers/zaza#430
Change-Id: I4100771916963b681e760f5e364420f50dc81b9f
Tenacity was removed as a) it introduced another point for async code to run (which was really confusing to debug) and b) seemed overly complex for the retries that are needed. This simplifies the retry code to make it very obvious where the async handovers are.
ajkavanagh
changed the title
lourot
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes broken destroy model functionality.
Also, updated the tox.ini/bundles so that the func-test-suite runs consecutive models using the same controller (i.e. exercises the destroy model feature).
Fixes-Bug: #425