Option --test-directory is not used for overlays

[rgildein]

Using the --test-directory option does not work for overlays, as they are searched in a folder defined only by constants.

An example of how I wanted to use it.

$ tree tests/functional 
tests/functional
├── bundles
│   ├── openstack.yaml
│   └── overlays
│       └── openstack.yaml.j2
├── requirements.txt
└── tests.yaml

# tox.ini
commands =
    functest-run-suite --test-directory {toxinidir}/tests/functional --bundle openstack --keep-model {posargs}

Such a run of functional tests does not take into account the openstack.yaml.j2 overlay.

[ajkavanagh]

It's a little bit complicated, but this is indeed a missing feature. The reason is largely because render_overlay(...) calls get_template(...), but doesn't pass a template_dir.

This also happens in render_local_overlay(...) - again a template_dir is not passed and the default constant is used.

However, in deploy_bundle(...) the right thing is done.

Essentially, to fix this, the template_dir parameter needs to be set in the call to get_template() everywhere it is called.