Use zaza.model.get_unit_public_address() #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the use of "unit.public_address" with
zaza.model.get_unit_public_address().
AssertionError: {'host': '172.16.0.25', 'port': 3306, 'user': 'prom_exporter'} != {'host': None, 'port': 3306, 'user': 'prom_exporter'}
- {'host': '172.16.0.25', 'port': 3306, 'user': 'prom_exporter'}
? ^^^^^^^^^^^^^
+ {'host': None, 'port': 3306, 'user': 'prom_exporter'}
Related-Bug: openstack-charmers/zaza#472
|
This PR is exercised by https://review.opendev.org/c/openstack/charm-mysql-innodb-cluster/+/876740 |
openstack-mirroring
pushed a commit
to openstack/charm-mysql-innodb-cluster
that referenced
this pull request
Mar 23, 2023
The zosci 3rd party CI has updated to using focal and tox 4 by default for the runners, so these fixes ensure that the main development branch continues to be compatible. Change-Id: I95c5cf033ce077664c7a221d43b13dfe8d3ac504 Func-Test-Pr: openstack-charmers/zaza-openstack-tests#1028
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Mar 23, 2023
* Update charm-mysql-innodb-cluster from branch 'master'
to c43ae5147e0303c04fe70d9bd0aaa4bd696939f1
- Fixes for tox 4 on focal (ZOSCI system)
The zosci 3rd party CI has updated to using focal and tox 4 by default
for the runners, so these fixes ensure that the main development branch
continues to be compatible.
Change-Id: I95c5cf033ce077664c7a221d43b13dfe8d3ac504
Func-Test-Pr: openstack-charmers/zaza-openstack-tests#1028
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the use of "unit.public_address" with
zaza.model.get_unit_public_address().
Related-Bug: openstack-charmers/zaza#472