Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.16] OCPBUGS-44527: ib-sriov-cni FIPS compliance #65

Open
wants to merge 7 commits into
base: release-4.16
Choose a base branch
from
Open

[release-4.16] OCPBUGS-44527: ib-sriov-cni FIPS compliance #65

wants to merge 7 commits into from
+40,215 −15,772

Conversation

SchSeba
Copy link
Contributor

@SchSeba SchSeba commented Nov 19, 2024

No description provided.

SchSeba and others added 7 commits November 19, 2024 13:12
@SchSeba
Add Snyk config
73bd56d 
Signed-off-by: Sebastian Sch <[email protected]>
@adrianchiris @SchSeba
Update packages
c43ffc8 
this commit updates several packages to their
latest version such as cni plugins, rdma cni,
ginkgo, gomega.

in addition update local imports to point to
k8snetworkplumbingwg instead of Mellanox org

Signed-off-by: adrianc <[email protected]>
Signed-off-by: Sebastian Sch <[email protected]>
@adrianchiris @SchSeba
Cleanup & Maintenance
6ca5f40 
- refactor makefile, clean up unused targets
  remove the use of .gopath, restructure and add
  target description
- update .gitignore file
- add test-image target to buildtest workflow

Signed-off-by: adrianc <[email protected]>
@SchSeba
switch the golangci install method (#86)
a9e0728 
Signed-off-by: Sebastian Sch <[email protected]>
@SchSeba
Allow the configure golang flags (#90)
30c6568 
Signed-off-by: Sebastian Sch <[email protected]>
@SchSeba
remove no_openssl
8136834 
Signed-off-by: Sebastian Sch <[email protected]>
@SchSeba
d/s switch cgo to 1
3218901 
Signed-off-by: Sebastian Sch <[email protected]>
@SchSeba SchSeba changed the title [release-4.16] Fips support [release-4.16] OCPBUGS-44527: ib-sriov-cni FIPS compliance Nov 19, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 19, 2024
@openshift-ci-robot
Copy link
Contributor

@SchSeba: This pull request references Jira Issue OCPBUGS-44527, which is invalid:

  • expected dependent Jira Issue OCPBUGS-43434 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 19, 2024
@SchSeba SchSeba mentioned this pull request Nov 19, 2024
Closed
@openshift-ci openshift-ci bot requested review from bn222 and dougbtv November 19, 2024 11:18
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 19, 2024

@SchSeba: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@zeeke
Copy link
Contributor

zeeke commented Nov 20, 2024

/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 20, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SchSeba, zeeke
Once this PR has been reviewed and has the lgtm label, please assign dougbtv for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bn222 bn222 Awaiting requested review from bn222

@dougbtv dougbtv Awaiting requested review from dougbtv

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@weliang1 weliang1

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@evgenLevin evgenLevin

@yingwang-0320 yingwang-0320

@qiowang721 qiowang721

Labels
backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.