Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wif config cluster create option #644

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

JakobGray
Copy link
Contributor

@JakobGray JakobGray commented Jul 19, 2024

Issue: https://issues.redhat.com/browse/OCM-8008

  • Adds --wif-config flag for cluster create
  • Adds interactive prompt following CCS for authentication method

Interactive view (select auth type):

? CCS: Yes
? Method of authenticating GCP cluster
? Authentication method:  [Use arrows to move, type to filter]
> Workload Identity Federation (WIF)
  Service account

Interactive view (select WIF config to use):

? CCS: Yes
? Authentication method: Workload Identity Federation (WIF)
? Specifies the GCP Workload Identity Federation config used to authenticate.
? WIF Configuration:  [Use arrows to move, type to filter]
> jdg01 (2crdj6l18l0uqfoqq4873a4alp0t9v4r)

Create cluster help view:

Usage:
  ocm create cluster [flags] NAME

Flags:
      --wif-config string                                     Specifies the GCP Workload Identity Federation config used to authenticate.

@JakobGray
Copy link
Contributor Author

@ckandag @renan-campos

@JakobGray JakobGray marked this pull request as ready for review July 30, 2024 18:14
Copy link
Collaborator

@renan-campos renan-campos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Going to do a quick run locally and then I'll merge it

pkg/provider/wif_configs.go Show resolved Hide resolved
pkg/provider/wif_configs.go Show resolved Hide resolved
pkg/provider/wif_configs.go Outdated Show resolved Hide resolved
@ckandag ckandag merged commit 57ce1d5 into openshift-online:main Aug 5, 2024
4 of 5 checks passed
@JakobGray JakobGray deleted the OCM-8008 branch August 5, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants