-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCM-7377: Add registry allowlists and cluster registry config #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I guess the default step is adding new features to both API, right? |
lucasponce
reviewed
Aug 27, 2024
I assume so from the latest changes, yes |
lucasponce
reviewed
Aug 27, 2024
andreadecorte
force-pushed
the
OCM-7376
branch
from
August 27, 2024 10:01
a912392
to
6584117
Compare
lucasponce
reviewed
Aug 27, 2024
lucasponce
reviewed
Aug 27, 2024
model/clusters_mgmt/v2alpha1/cluster_registry_config_type.model
Outdated
Show resolved
Hide resolved
Add a new root endpoint: - Registry allowlist And a new cluster type part - Registry config to both v1 and v2alpha1 model
andreadecorte
force-pushed
the
OCM-7376
branch
from
August 27, 2024 10:37
6584117
to
8dbef6b
Compare
Payload example:
|
andreadecorte
changed the title
OCM-7376: Add registry allowlists and cluster registry config
OCM-7377: Add registry allowlists and cluster registry config
Aug 27, 2024
lucasponce
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new root endpoint:
to both v1 and v2alpha1 model