Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add node drain grace period to the NodePool model #910

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Add node drain grace period to the NodePool model #910

merged 2 commits into from
Mar 7, 2024

Conversation

philipwu08
Copy link
Contributor

@mikeshng
Copy link
Contributor

mikeshng commented Mar 5, 2024

/lgtm

andreadecorte
andreadecorte reviewed Mar 6, 2024
View reviewed changes
model/clusters_mgmt/v1/node_pool_type.model Outdated
@@ -50,4 +50,7 @@ class NodePool {

// The names of the tuning configs for this node pool.
TuningConfigs []String

// Time to wait on upgrades for a NodePool to drain before it is removed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is also for replace operations, not only upgrades

@philipwu08 philipwu08 force-pushed the node-drain-hcp branch 3 times, most recently from 75e5702 to fae742e Compare March 7, 2024 14:51
@hunterkepley hunterkepley merged commit c7c6162 into openshift-online:main Mar 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreadecorte andreadecorte andreadecorte left review comments

@gdbranco gdbranco gdbranco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@philipwu08 @mikeshng @andreadecorte @gdbranco @hunterkepley