Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the NewRESTFullAPIWatcherStore client resilient and reliable on full resync #131

Closed
machi1990 opened this issue Jun 14, 2024 · 2 comments

Comments

@machi1990
Copy link
Contributor

This is to track #104 (comment)
The client I was using is similar to https://github.com/openshift-online/maestro/blob/main/examples/manifestworkclient/client-a/main.go

and I toggled WithResyncEnabled(true) to true
/cc @skeeey

@skeeey
Copy link
Contributor

skeeey commented Jun 20, 2024

The resync is only for the client that has the local cache, in our case, the client does not have the local cache, so we should not enable the resync

I enhanced the RESTFulAPIWatcherStore in #133, it will list works from maestro server when a watcher is required, so that we have a full sync when a client is created

@clyang82
Copy link
Contributor

The issue was fixed. free feel to reopen it if you have any questions. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants