-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
correlation alerts #877
base: main
Are you sure you want to change the base?
correlation alerts #877
Conversation
Signed-off-by: Surya Sashank Nistala <[email protected]>
src/main/java/org/opensearch/securityanalytics/model/CorrelationAlert.java
Show resolved
Hide resolved
Signed-off-by: Surya Sashank Nistala <[email protected]>
"correlation_id": { | ||
"type": "keyword" | ||
}, | ||
"correlation_rule_name": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be correlation_rule_names? to remain consistent with CorrelationAlert
Signed-off-by: Surya Sashank Nistala <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this?
correlation_id": {
"type": "nested",
"properties": {
"correlation_rule_ids": {
"type": "keyword"
},
"correlation_rule_names": {
"type": "keyword"
}
}
}
Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: Surya Sashank Nistala <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #877 +/- ##
============================================
- Coverage 24.82% 24.30% -0.52%
+ Complexity 1030 1029 -1
============================================
Files 277 280 +3
Lines 12717 12966 +249
Branches 1401 1420 +19
============================================
- Hits 3157 3152 -5
- Misses 9296 9550 +254
Partials 264 264 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: Surya Sashank Nistala <[email protected]>
this.xContentRegistry = xContentRegistry; | ||
} | ||
|
||
public void getCorrelationAlerts(ActionListener<CorrelationAlertsList> listener, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can we move the ActionListener as the last parameter for consistency?
Signed-off-by: Surya Sashank Nistala <[email protected]>
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.