Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] All system index interactions should happen in a stashed context #1182

Open
goyamegh opened this issue Jul 18, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@goyamegh
Copy link
Collaborator

What is the bug?
As part of fixing the security tests, we observed some failing integ tests in the context of security enabled workflow. Verified this by opening new PRs after the latest docker image got published here: #1172.

After a small test in test PR: #1179, it was found that some of the system index interactions in the plugin are happening outside the stashed context, causing the tests to fail. Once this is fixed, we should be able re-run the security tests successfully.

Sample reference: opensearch-project/job-scheduler#347

How can one reproduce the bug?
Steps to reproduce the behavior:

  1. Go to any PR in main or 2.x
  2. Check the security tests are failing, while non-security enabled integ tests are passing.

What is the expected behavior?
Security enabled integ tests should pass

What is your host/environment?

  • OS: [e.g. iOS] - linux, macOs, windows
  • Version [e.g. 22] - main and 2.x
  • Plugins - SAP

Do you have any screenshots?
NA

Do you have any additional context?
Add any other context about the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants