Add Gradle Wrapper Validation Starter Workflow #118
Conversation
dbwiddis
requested review from
CEHENKLE,
dblock,
mch2,
peternied and
saratvemulapalli
as code owners
Signed-off-by: Daniel Widdis <[email protected]>
There was a problem hiding this comment.
So why are we adding this to .github? I think a copy of this belong in all gradle repos and some documentation should be added to https://github.com/opensearch-project/opensearch-plugins.
Yeah, I misread some documentation and thought everything in .github replicated including workflows. It's not quite that way. Many templates do, but it seems I should put it in a Putting this to draft until I have time to follow up. |
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
requested review from
dblock
and removed request for
mch2,
peternied,
saratvemulapalli and
CEHENKLE
dbwiddis
changed the title
There was a problem hiding this comment.
I think this should be called gradle-wrapper because it will apply to a subset of repos.
I'm still uneasy about putting this in .github because it only applies to a subset of repos, while everything here seems to apply to all repos. Is there really no better place? 😞
The "filePatterns": [
"^gradlew$",
"^gradlew.bat$"
]
Per this link it's the only place for this templated approach. I'm ok with just closing this PR if you don't think we need starter workflows, and just want to host an example somewhere like |
I think that would be best. |
|
Closing in favor of an edit to workflow section of |
Signed-off-by: Daniel Widdis [email protected]
Description
Adds a template for the Gradle Wrapper Validation Action to run organization-wide.
This will provide an easy path for repo maintainers to add this workflow with a few mouse clicks.
Issues Resolved
Closes opensearch-project/opensearch-plugins#199
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.