Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META] Backport Windows Support for 1.x #181

Open
21 of 25 tasks
rishabh6788 opened this issue Nov 28, 2022 · 6 comments
Open
21 of 25 tasks

[META] Backport Windows Support for 1.x #181

rishabh6788 opened this issue Nov 28, 2022 · 6 comments

Comments

@rishabh6788
Copy link

rishabh6788 commented Nov 28, 2022

Is your feature request related to a problem?

Coming from opensearch-project/opensearch-build#33. In order to support a Windows x64 distribution for OpenSearch 1.x each plugin needs to backport Windows CI to their 1.x branch and include tools that are windows-specific as replacements for any bash scripts.

What solution would you like?

Every component has passing CI on Windows (windows-latest on GHA), including unit, integration and bcw tests for 1.x branch, and has Windows-specific documentation, if needed.

OpenSearch

Dashboards

@peternied
Copy link
Member

@rishabh6788 Can you provide the background on why we want to do this work?

Its a considerable investment for the Security plugin since its build infrastructure was rewritten for OpenSearch 2.X and I would rather focus on supporting existing platforms and new features going forward.

@CEHENKLE
Copy link
Member

@rishabh6788 Can you provide the background on why we want to do this work?

As a general principal, when we provide support for a distribution, we provide it for all or the releases we support. Since we currently support 1.x and 2.x, it means they both need to have windows distributions.

If we don't do it this way, it means that we need to maintain a matrix somewhere for customer to go figure out what's supported where, which I think is a suboptimal experience.

@peternied
Copy link
Member

we need to maintain a matrix somewhere for customer to go figure out what's supported where

We already do this on the downloads page [1] by pushing customers to follow a link for 1.x releases.

Are there customers interested in running 1.3 version of OpenSearch on Windows and are not interested in running 2.4? It would be a much easier for me to understand if we had a ready and waiting audience as opposed to an ideal.

image

[1] From https://opensearch.org/downloads.html

@dblock
Copy link
Member

dblock commented Nov 30, 2022

I am surprised we want Windows support in 1.x. It's a new platform, so what kind of user would want to start on an already legacy version of OpenSearch that is only receiving security fixes?

@CEHENKLE
Copy link
Member

CEHENKLE commented Nov 30, 2022

@dblock @peternied Barani's out, but my understanding is that we have customers who have wanted windows for the last year+, but we didn't offer it so they've made do (or rolled their own). Ideally, we would have launched 1.0 with Windows. We didn't so now we're playing catch up.

@peternied
Copy link
Member

Recapping from offline - the Security team is all in to support Windows. I've updated the issues associated with security/security-dashboard-plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants