-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Out of the box New Relic PHP agent support #216
Comments
I would not use Guzzle when we change the HTTP client. https://www.php-fig.org/psr/psr-7/ and https://www.php-fig.org/psr/psr-18/ are better I think. Just using Guzzle because a random provider has support for it feels wrong, and in my opinion, they developed it wrong. They should instrument |
I started upgrading Guzzle in https://github.com/dblock/opensearch-php/tree/upgrade-guzzle. There are ... a lot of changes. |
I merged #233 which introduced PSR interfaces and should enable this out of the box. Could use some help testing and fixing anything broken before we do a release. |
Is your feature request related to a problem?
Using OpenSearch client in combination with New Relic (e.g. when migrating from Elasticsearch)
does not work immediately. I.e. OpenSearch client does not get instrumented, so no span for the OpenSearch requests gets created. So the time the OpenSearch request takes gets attributed to time spend in PHP in New Relic.
This distorts and complicates run-time analysis.
The reason is using an old and relatively unmaintained dependency
ezimuel/ringphp
instead of up to date version of Guzzle Library.See here))) and here
What solution would you like?
Upgrade to work with Guzzle HTTP client library 7
What alternatives have you considered?
Dealing with custom instrumentation
Do you have any additional context?
none
The text was updated successfully, but these errors were encountered: