diff --git a/CHANGELOG.md b/CHANGELOG.md
index a3cf2bb8dd..3f17786f26 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -9,6 +9,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- Bumps `xunit.runner.visualstudio` from 2.5.0 to 2.5.3
- Bumps `Octokit` from 7.1.0 to 9.0.0
- Bumps `FSharp.Core` from 7.0.400 to 7.0.401
+- Bumps `xunit` from 2.4.2 to 2.6.1
## [1.5.0]
### Fixed
diff --git a/abstractions/src/OpenSearch.OpenSearch.Xunit/OpenSearch.OpenSearch.Xunit.csproj b/abstractions/src/OpenSearch.OpenSearch.Xunit/OpenSearch.OpenSearch.Xunit.csproj
index 319f144aa5..b333b85aff 100644
--- a/abstractions/src/OpenSearch.OpenSearch.Xunit/OpenSearch.OpenSearch.Xunit.csproj
+++ b/abstractions/src/OpenSearch.OpenSearch.Xunit/OpenSearch.OpenSearch.Xunit.csproj
@@ -8,7 +8,7 @@
true
-
+
diff --git a/tests/Tests.Core/Tests.Core.csproj b/tests/Tests.Core/Tests.Core.csproj
index 773568501c..3243ce950d 100644
--- a/tests/Tests.Core/Tests.Core.csproj
+++ b/tests/Tests.Core/Tests.Core.csproj
@@ -15,7 +15,7 @@
-
+
diff --git a/tests/Tests/CommonOptions/AutoExpandReplicas/AutoExpandReplicasTests.cs b/tests/Tests/CommonOptions/AutoExpandReplicas/AutoExpandReplicasTests.cs
index b2830fcfe1..92cce15af4 100644
--- a/tests/Tests/CommonOptions/AutoExpandReplicas/AutoExpandReplicasTests.cs
+++ b/tests/Tests/CommonOptions/AutoExpandReplicas/AutoExpandReplicasTests.cs
@@ -53,7 +53,7 @@ public void ImplicitConversionFromMinAndMaxString()
autoExpandReplicas.MinReplicas.Should().Be(0);
autoExpandReplicas.MaxReplicas.Match(
i => i.Should().Be(5),
- s => Assert.True(false, "expecting a match on integer"));
+ s => Assert.Fail("expecting a match on integer"));
autoExpandReplicas.ToString().Should().Be(minAndMax);
}
@@ -67,7 +67,7 @@ public void ImplicitConversionFromMinAndAllString()
autoExpandReplicas.Enabled.Should().BeTrue();
autoExpandReplicas.MinReplicas.Should().Be(0);
autoExpandReplicas.MaxReplicas.Match(
- i => Assert.True(false, "expecting a match on string"),
+ i => Assert.Fail("expecting a match on string"),
s => s.Should().Be("all"));
autoExpandReplicas.ToString().Should().Be(minAndMax);
@@ -82,7 +82,7 @@ public void CreateWithMinAndMax()
autoExpandReplicas.MinReplicas.Should().Be(2);
autoExpandReplicas.MaxReplicas.Match(
i => i.Should().Be(3),
- s => Assert.True(false, "expecting a match on integer"));
+ s => Assert.Fail("expecting a match on integer"));
autoExpandReplicas.ToString().Should().Be("2-3");
}
@@ -95,7 +95,7 @@ public void CreateWithMinAndAll()
autoExpandReplicas.Enabled.Should().BeTrue();
autoExpandReplicas.MinReplicas.Should().Be(0);
autoExpandReplicas.MaxReplicas.Match(
- i => Assert.True(false, "expecting a match on string"),
+ i => Assert.Fail("expecting a match on string"),
s => s.Should().Be("all"));
autoExpandReplicas.ToString().Should().Be("0-all");
diff --git a/tests/Tests/Indices/IndexSettings/GetIndexSettings/GetIndexSettingsApiTests.cs b/tests/Tests/Indices/IndexSettings/GetIndexSettings/GetIndexSettingsApiTests.cs
index 8ce0fc3450..e67d6084f9 100644
--- a/tests/Tests/Indices/IndexSettings/GetIndexSettings/GetIndexSettingsApiTests.cs
+++ b/tests/Tests/Indices/IndexSettings/GetIndexSettings/GetIndexSettingsApiTests.cs
@@ -81,7 +81,7 @@ protected override void ExpectResponse(GetIndexSettingsResponse response)
index.Settings.AutoExpandReplicas.Should().NotBeNull();
index.Settings.AutoExpandReplicas.MinReplicas.Should().Be(0);
index.Settings.AutoExpandReplicas.MaxReplicas.Match(
- i => { Assert.True(false, "expecting a string"); },
+ i => { Assert.Fail("expecting a string"); },
s => s.Should().Be("all"));
index.Settings.AutoExpandReplicas.ToString().Should().Be("0-all");
}
diff --git a/tests/Tests/Search/Request/HighlightingUsageTests.cs b/tests/Tests/Search/Request/HighlightingUsageTests.cs
index 7a05eee5a3..491475435d 100644
--- a/tests/Tests/Search/Request/HighlightingUsageTests.cs
+++ b/tests/Tests/Search/Request/HighlightingUsageTests.cs
@@ -298,7 +298,7 @@ protected override void ExpectResponse(ISearchResponse response)
}
}
else
- Assert.True(false, $"highlights contains unexpected key {highlightField.Key}");
+ Assert.Fail($"highlights contains unexpected key {highlightField.Key}");
}
}
}
diff --git a/tests/Tests/Search/Request/HighlightingUsageTestsWithMaxAnalyzerOffset.cs b/tests/Tests/Search/Request/HighlightingUsageTestsWithMaxAnalyzerOffset.cs
index 63faf46347..ffe5b5ddff 100644
--- a/tests/Tests/Search/Request/HighlightingUsageTestsWithMaxAnalyzerOffset.cs
+++ b/tests/Tests/Search/Request/HighlightingUsageTestsWithMaxAnalyzerOffset.cs
@@ -154,8 +154,8 @@ public HighlightingUsageTestsWithMaxAnalyzerOffset(ReadOnlyCluster cluster, Endp
};
protected override Func, ISearchRequest> Fluent => s => s
-
-
+
+
.Query(q => q
.Match(m => m
.Field(f => f.Name.Suffix("standard"))
@@ -308,7 +308,7 @@ protected override void ExpectResponse(ISearchResponse response)
}
}
else
- Assert.True(false, $"highlights contains unexpected key {highlightField.Key}");
+ Assert.Fail($"highlights contains unexpected key {highlightField.Key}");
}
}
}
diff --git a/tests/Tests/Search/Request/SourceFilteringUsageTests.cs b/tests/Tests/Search/Request/SourceFilteringUsageTests.cs
index 30a80db089..7639ac9767 100644
--- a/tests/Tests/Search/Request/SourceFilteringUsageTests.cs
+++ b/tests/Tests/Search/Request/SourceFilteringUsageTests.cs
@@ -133,7 +133,7 @@ public void CanDeserializeBoolean()
falseCase.SourceFilter.Should().NotBeNull();
falseCase.SourceFilter.Match
(b => b.Should().BeFalse(),
- f => Assert.True(false, "Expected bool but found ISourceFilter")
+ f => Assert.Fail("Expected bool but found ISourceFilter")
);
var trueCase = Expect("{ \"_source\": true }").DeserializesTo();
@@ -141,7 +141,7 @@ public void CanDeserializeBoolean()
trueCase.SourceFilter.Should().NotBeNull();
trueCase.SourceFilter.Match
(b => b.Should().BeTrue(),
- f => Assert.True(false, "Expected bool but found ISourceFilter")
+ f => Assert.Fail("Expected bool but found ISourceFilter")
);
}
@@ -151,7 +151,7 @@ public void CanDeserializeArray()
var o = Expect("{ \"_source\": [\"obj.*\"] }").DeserializesTo();
o.Should().NotBeNull();
o.SourceFilter.Match(
- b => Assert.True(false, "Expected ISourceFilter but found bool"),
+ b => Assert.Fail("Expected ISourceFilter but found bool"),
f =>
{
f.Should().NotBeNull();
@@ -166,7 +166,7 @@ public void CanDeserializeString()
var o = Expect("{ \"_source\": \"obj.*\" }").DeserializesTo();
o.Should().NotBeNull();
o.SourceFilter.Match(
- b => Assert.True(false, "Expected ISourceFilter but found bool"),
+ b => Assert.Fail("Expected ISourceFilter but found bool"),
f =>
{
f.Should().NotBeNull();
@@ -181,7 +181,7 @@ public void CanDeserializeObject()
var o = Expect("{ \"_source\": { \"includes\": [\"obj.*\"], \"excludes\": [\"foo.*\"] } }").DeserializesTo();
o.Should().NotBeNull();
o.SourceFilter.Match(
- b => Assert.True(false, "Expected ISourceFilter but found bool"),
+ b => Assert.Fail("Expected ISourceFilter but found bool"),
f =>
{
f.Should().NotBeNull();