-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] OpenTelemetry / Monitoring support #934
Comments
@clovis1122 Are you saying you'd like to instrument the client? We'd like this. Are there clients that you know do it well? |
So, I don't have an example of an OpenSearch client with OpenTelemetry instrumentation, or any similar client that can be used as an example. Although I recently saw some code on drizzle-orm that looks like a good way to implement it. To add a bit more about my particular use case - I'm using Sentry for APM & I wrapped the call to
I also get automatic instrumentation from node's http clients which this project uses. What I am noticing is that most of the times, my custom span instrumentation and node's http call happen within 10ms which is okay. However, sometimes I see 250ms difference between them, like here: Having OpenTelemetry instrumentation built into the client would help me better understand the time spent there. The other big spender I have is this one, but since most of the time is spent on the http request, I guess it has nothing to do with the client (so, adding APM may not help me at all). The first request seems to end on a socket hang up error, and so, it requires a second request to complete. |
Makes sense @clovis1122. Would be awesome if someone (you?) could add this to the client. |
Is your feature request related to a problem?
I'm trying to troubleshoot a performance issue.
What solution would you like?
It would be nice if OpenSearch had some basic open telemetry support. I'm using Sentry, and would like to have how long OpenSearch requests are taking on my performance tab.
What alternatives have you considered?
Manually tracking the OpenSearch requests for now...
Do you have any additional context?
The text was updated successfully, but these errors were encountered: