[BUG] Test assertions failing

[tejeshreddy]

What is the bug?

A couple of asserts in the test suite are failing. For all these tests, the expected req.headers.connection is close whereas the actual value is keep-alive

Below are the tests that are failing.

• test: test/unit/client.test.js Disable keep alive agent
• test: test/unit/connection.test.js Disable keep alive

Do you have any additional context?

test summary

 FAIL ​ test/unit/client.test.js 1 failed of 122 13s
 ✖ should be equal

 FAIL ​ test/unit/connection.test.js 2 failed of 86 4s
 ✖ should match pattern provided
 ✖ should match pattern provided

[dblock]

Is this local? The build is passing on main here.

[tejeshreddy]

If that's the case, this could be a local issue.

[dblock]

@tejeshreddy do check and find the root cause! It could be that our CI is not reporting errors 😱

[tejeshreddy]

@dblock Sure thing, I will take a look at this. I'll keep you posted on my findings.

[tejeshreddy]

I've checked one of the latest CI pipeline execution - Unit test and the same set of test cases seem to be passing. Starting to wonder if this issue is purely local/just my local.

[dblock]

I've checked one of the latest CI pipeline execution - Unit test and the same set of test cases seem to be passing. Starting to wonder if this issue is purely local/just my local.

Good. You should dig up why this happens!

[nhtruong]

Haven't run into this myself and the tests till pass on Github. Closing since it's stale. Feel free to reopen if you think this is still a valid issue.