Check for inequality in ISM tests #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kshitij Tandon <[email protected]>
tandonks
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam,
raintygao,
zhongnansu and
yujin-emma
as code owners
ruanyl
approved these changes
Nov 4, 2024
SuZhou-Joe
approved these changes
Nov 4, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 4, 2024
Signed-off-by: Kshitij Tandon <[email protected]> (cherry picked from commit 8411d69)
SuZhou-Joe
pushed a commit
that referenced
this pull request
Nov 4, 2024
Signed-off-by: Kshitij Tandon <[email protected]> (cherry picked from commit 8411d69) Co-authored-by: Kshitij Tandon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When testing against cluster with more than one node, we encounter that this check fails as total number of uncommitted operations will be as per replica configuration. Eg. for a 1:1 pri:rep case, total number of uncommitted operations will be two (one for primary, one for replica), so modifying the check to check for inequality instead
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.